I'm always up for good lighting in the city, but like everything, it needs to be well-implemented and suit the building/street it's on. That Shangri-La example doesn't really look that good.
I was in Hong Kong a couple of months ago, and took some pictures of decent lighting around Fortress Hill. HK, being HK, can get away with all kinds of neat and disastrous lighting set-ups.
The AIA building is a lesser-known building in the city, but looks nice at night.
Kowloon's skyline is starting to give HK Island's a run for it's money (not really). The minimal lighting effects on each building brings them together, and punches up the cityscape at night.
And totally unrelated, but hey, I love stopping in at Triple Os whenever I'm in Hong Kong for a little taste of home.
Shanghai's lighting is a bit more scant than HK's. In Shanghai, it seems to be more about flood lights. As long as the buildings look good, I don't see anything wrong with taking that approach.
The Jin Mao has never had any lighting attached to it except for the crown. It's lit up by flood lights nightly.
This new twin tower complex nearby takes the same approach.
The SWFC combines attached lighting and flood lights for a nice look overall - though they seems to be constantly fixing the blue LEDs that outline the tower. The Jin Mao had yet to be lit up that night.